Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common csm-base-image. #232

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Use common csm-base-image. #232

merged 10 commits into from
Jan 23, 2025

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Jan 21, 2025

Description

Use the common csm-base-image instead of always building a local base image. The benefit is that it will now be possible to build images on non RHEL VMs and as a non root user.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1691

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built image and ran image to validate that the program will start up and run. Not able to perform e2e due to lack of ObjectScale environment.

Special Notes For Your Reviewer:

Please describe the parts of code reviewers should focus on.

Additional documentation

  • Enhancement proposals
  • Usage documentation

Copy link

@santhoshatdell santhoshatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donatwork
"csm-base-image:nightly" - Where is this built and pushed to quay.io on a regular basis?

@donatwork
Copy link
Contributor Author

@donatwork "csm-base-image:nightly" - Where is this built and pushed to quay.io on a regular basis?

It is built in the nightly TechOps pipeline. It's the first image that is built, tagged, and pushed.

@donatwork donatwork enabled auto-merge (squash) January 23, 2025 18:39
@donatwork donatwork merged commit d4e27dc into main Jan 23, 2025
7 checks passed
@donatwork donatwork deleted the csm-base-image branch January 23, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants