Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Authorization v2 support for CSM 1.13 #1409

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Update Authorization v2 support for CSM 1.13 #1409

merged 1 commit into from
Jan 10, 2025

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Jan 10, 2025 •
edited
Loading

Description

Update Authorization v2 to 2.1.0 support for CSM 1.13.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit acf226d. ± Comparison against base commit ff66edd.

@chimanjain chimanjain marked this pull request as ready for review January 10, 2025 06:28
mgandharva
mgandharva approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gilltaran
gilltaran approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@gilltaran gilltaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rajkumar-palani
rajkumar-palani requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you verify the checklist of this PR?

rajkumar-palani
rajkumar-palani approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chimanjain chimanjain merged commit 1fda5c8 into main Jan 10, 2025
7 checks passed
@chimanjain chimanjain deleted the usr/chiman_jain/update-auth-v2 branch January 10, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgandharva mgandharva mgandharva approved these changes

@panigs7 panigs7 panigs7 approved these changes

@gilltaran gilltaran gilltaran approved these changes

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chimanjain @rajkumar-palani @gilltaran @panigs7 @mgandharva