Install and upgrade csi-powemax with reverse proxy secret #1423
Conversation
- csireverseproxy.secretName is changed in favor of csireverseproxy.useSecret and global.defaultCredentialsSecret to match operator install implementation. - default value for global.defaultCredentialsSecret changed to "powermax-config" to match operator implementation
lukeatdell
requested review from
gallacher,
mjsdell,
prablr79,
rajkumar-palani,
AronAtDell,
sharmilarama and
rsedlock1958
as code owners
- Changing wording in upgrade instructions. - Rearranging examples and details for the secret creation. - Fixed installation step numbering.
| ```bash | ||
| cd ../dell-csi-helm-installer && ./csi-install.sh --namespace powermax --values ./my-powermax-settings.yaml --upgrade --helm-charts-version <version> | ||
| kubectl create secret generic powermax-config --namespace powermax --from-file=config=samples/secret/secret.yaml |
There was a problem hiding this comment.
I would think the user knows that the directory to be in is the csi-powermax directory but in other places we indicate to work in the repo directory.
There was a problem hiding this comment.
The reason I added it is because we offer the 'copy' option for these bash examples. I'm of the opinion, as the user follows along, they should be able to copy and paste the commands into their terminal and it should work, nearly all the time, with as little editing as possible.
I agree, most users will know where they are in the directory tree, so it is a bit redundant, but this removes any ambiguity and simplifies the install process.
But thanks for mentioning this. I was able to improve the flow of the upgrade instructions with this feedback!
- add a few bash examples to allow easier copy-pasting of commands during upgrade
Description
Updating install and upgrade documentation to guide users through the process of installing and upgrading csi-powermax using the reverse proxy secret.
GitHub Issues
Checklist:
Have you added high-resolution images?Not applicable