Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chktex highlighting wrong column when using tabs instead of spaces #4661

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Fix chktex highlighting wrong column when using tabs instead of spaces #4661

merged 4 commits into from
Jan 14, 2024

Conversation

Jorenar
Copy link
Contributor

@Jorenar Jorenar commented Nov 24, 2023

Fixes #723

chktex implemented bug #56486: Allow setting options on the command line
Thanks to that we can tell it to treat tab character as of one space width, i.e. one char.
That means, after we translate the output back to Vim columns, we get correct numbers.

w0rp
w0rp previously requested changes Dec 10, 2023
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we might be missing a test for the chtex command, or one might be broken by this. Could you add a test or edit one? See :help ale-dev.

@Jorenar
Copy link
Contributor Author

Jorenar commented Dec 16, 2023

Yeah, there's no command test. I'll try writing one then

Fixes #723

chktex implemented feature request [1] for allowing setting options from
the command line. Thanks to that we can tell it to treat tab character
as of one space width, i.e. one char. That means, after we translate the
output back to Vim columns, we get correct numbers.

[1]: https://savannah.nongnu.org/bugs/?56486
@Jorenar Jorenar requested a review from w0rp December 25, 2023 02:13
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me.

@hsanson hsanson dismissed w0rp’s stale review January 14, 2024 12:04

PR now contains test for the command.

@hsanson hsanson merged commit 94f7646 into dense-analysis:master Jan 14, 2024
7 checks passed
hsanson added a commit to hsanson/ale that referenced this pull request Feb 22, 2024
@hsanson hsanson mentioned this pull request Feb 22, 2024
hsanson added a commit that referenced this pull request Feb 26, 2024
* Fix 4712 - revert #4661

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong elements highlighted when using tabs instead of spaces (at least on LaTeX)
3 participants