Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force --no-fix when ruff used as a linter #4759

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

yining
Copy link
Contributor

@yining yining commented Apr 19, 2024

this commit is to fix #4756 which suggests to force disable applying fixes when linting, particularly when fix = true was set in project pyproject.toml file.

The flag --no-fix was added without checking the version of ruff at this moment as it seems to be available in a quite early version.

this commit is to fix dense-analysis#4756 which suggests to force disable applying
fixes when linting, particularly when `fix = true` was set in project
`pyproject.toml` file.

The flag `--no-fix` was added without checking the version of `ruff` at
this moment as it seems to be available in a quite early version.
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@hsanson hsanson merged commit d19b238 into dense-analysis:master Apr 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should/could ALE pass --no-fix argument to ruff when linting (to override project configuration)?
2 participants