Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fact): null values comparison #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riezebosch
Copy link

@riezebosch riezebosch commented Jan 16, 2025

Expanded the null checks, we're facing this because right now we just add a lot of facts and cleanup the null values afterwards. You could consider use a record for Fact instead. Not sure if you consider supporting null values in facts, but it is not currently guarded either.

fixes #92

@dgm9704
Copy link
Owner

dgm9704 commented Jan 17, 2025

Thank you for taking the time to provide this fix!
However I would ask for you to first make a bug detailing the problem,
with steps to reproduce it and other information you think is pertinent.
I will then evaluate the situation and figure out what will be the solution.
(I tend to quite opinionated about the functionality and structure of the library,
and also about the code.)

@riezebosch
Copy link
Author

#92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullRef on Fact when Value is null
2 participants