Include changeset id in deletion #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about just having |
|
That makes sense to me. I'm not sure about @substack's original motivation for choosing this API. |
|
Can you also update the |
hackergrrl
reviewed
Feb 9, 2017
| @@ -172,6 +172,9 @@ DB.prototype._del = function (key, opts, cb) { | |||
| fields.refs.push.apply(fields.refs, v.refs) | |||
| } | |||
| }) | |||
| if (opts.value && opts.value.changeset) { | |||
There was a problem hiding this comment.
How about just checking for opts.changeset?
|
Let's nix this PR and update |
|
closing in favour of #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noffle could you review and add a test here (see the failing test in osm-p2p-server https://github.com/digidem/osm-p2p-db/compare/changeset-deletions) attempts to fix #34