Update to SQLAlchemy 2 style #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Engine.execute with Connection.execute - Ensure all raw SQL strings are wrapped in sqlalchemy.text - Use explicit bound parameter dicts (see https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#execute-method-more-strict-execution-options-are-more-prominent)
SQLAlchemy 2 added row.t as a synonym for row.tuple(), which broke this test. I've renamed the column t to ti to fix this.
acarapetis
force-pushed
the
sqlalchemy-2
branch
from
50447a9 to
0a97a18
Compare
|
Can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/test_pg.py::test_errors_and_messagesis failing for me, but it does so even with sqlbag@master and sqlalchemy 1.3, so not sure what's up there - perhaps a pg or psycopg2 config issue. All other tests are now passing with sqlalchemy 1.3 and 2.0.