Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLDR date/time format (avoid using alt pattern) #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhpijnacker-philips
Copy link

@rhpijnacker-philips rhpijnacker-philips commented Nov 18, 2024

The time-format for Swedish was changed from using : as a separator to using . with the last CLDR change.
We got feedback that this is not the preferred format. In the CLDR input, this is listed as the alt form:

<timeFormatLength type="short">
<timeFormat>
	<pattern draft="contributed">HH:mm</pattern>
	<pattern alt="variant">HH.mm</pattern>
</timeFormat>
</timeFormatLength>

In later versions of CLDR, the draft="contributed" tag is removed, confirming that the : form is indeed the preferred one.

I updated the stylesheet transform script to exclude the alt form for time- and date-formats, which exposed some other places where the alt form was incorrectly used.

See related PR dojo/dojo#446.

Copy link

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant