Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement importing multiple saves from an export folder #13278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoshuaVandaele
Copy link
Contributor

Implements https://bugs.dolphin-emu.org/issues/12887

image
image
image
image
image

This is my first PR for a feature, so I'd really appreciate feedback on what to improve and/or do differently!

@dreamsyntax
Copy link
Member

Don't consider this a blocker, just my opinion:
Is there a way we could combine the Import Wii Save... option with this?
Such that you could pick a folder or a save, or multi select some saves?
If this is out of scope, don't worry about it, just the first thought I had seeing this.

@JoshuaVandaele
Copy link
Contributor Author

I had looked into doing this at first, however neither Windows, Gnome, or OSX support selecting files and/or a directory at the same time in their native file dialog... So we'd have to make a custom file and/or folder selection widget, which I feel is a bit ugly and out of scope for this PR.

@AdmiralCurtiss
Copy link
Contributor

Haven't looked at the code in detail but this seems cool, definitely a usability improvement.

@jordan-woyak
Copy link
Member

image

I think it's usually preferred to have buttons with verbs like "Overwrite" and "Skip" instead of "Yes" and "No".

But if that's majorly inconvenient, I'd at least have an full empty line before the final line saying "Overwrite existing save?".

@JoshuaVandaele
Copy link
Contributor Author

JoshuaVandaele commented Jan 20, 2025

I think it's usually preferred to have buttons with verbs like "Overwrite" and "Skip" instead of "Yes" and "No".

But if that's majorly inconvenient, I'd at least have an full empty line before the final line saying "Overwrite existing save?".

I used the same text from the original "Import Wii Save" feature as much as possible, and this is one of those instances. I think this should be changed in a separate PR and/or commit. (Would it be fine to change within this PR in a separate commit?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants