-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DolphinQt: Replace MappingButton bold text with graphical indicators. #13283
base: master
Are you sure you want to change the base?
Conversation
d14261e
to
8c65457
Compare
MUCH better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nice thing that I didn't see highlighted in the video is that the indicators will show partial values in the range 0-1; timer(1)
demonstrates this well.
On my Windows 11 computer empty QLabels have a width of 6, which ButtonIndicator's sizeHint
divides in half to have a width of 3. Draw
then subtracts 2 to make room for the borders, meaning the actual indicator is only a single pixel wide and is a bit hard to see. I think having a platform-independent target width and adjusting it for the screen's DPI would be a better approach.
You clamp the input value to at most 1, but negative values will cause the indicator to cover the row of pixels forming the lower border, outside the intended indicator area.
8c65457
to
ae72a78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested new draw
The bold text was ugly and this is more visually similar to the other indicators.
Screencast_20250117_235817.webm