Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals / VideoCommon: update imgui to 1.91.7 and implot to v0.16 #13291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iwubcode
Copy link
Contributor

@iwubcode iwubcode commented Jan 20, 2025

In my editor PR branch, I track latest imgui. However, a recent update caused some additional changes to be needed. Rather than be conflict prone, I decided to move these changes to master.

…imgui changed types for ImTextureId, which was addressed by using an implicit cast
@dreamsyntax
Copy link
Member

dreamsyntax commented Jan 20, 2025

Tested on Windows with pretty much every Graphics Tab Advanced option there was.
Graphs, Projection, FPS etc all looked fine.
image

Copy link
Member

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested RetroAchievements encore mode notifications, status, and timer/leaderboards
with the linux (flatpak) build.
Everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants