InputCommon/ControllerEmu: Break out functionality of EmulatedController to eliminate redundant members. #13295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to eliminate redundant unused members in Wii Remote extension objects.
jordan-woyak
force-pushed
the
controller-emu-cleanup
branch
from
6febb44 to
3fb9213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wii Remote
Extensionclasses previously derived fromControllerEmugiving them redundant/unused "default device" and "expression variables" members.Common functionality has been moved to a
ControlGroupContainerclass.This eliminated the redundant members and some unnecessary function arguments.
Attachmentsconfig save/loading is now appropriately handled in an overridden virtual function instead of usingif (type == GroupType::Attachments).MapFloatandMapToFloatstatic member functions changed into more-appropriate free-functions.I'm mainly just moving code around here. Behaviors should be entirely unchanged.