-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mark rules #743
Update mark rules #743
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vi har et API for dette fra OW4: https://old.online.ntnu.no/api/v1/marks/rule-sets/
Kan vi bruke det i stedet?
Da får du også min approval til å fjerne tilsvarende i ow4 og redirecte til owf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kode-messig så er sånne "helpere" som inFuture
ikke nødvendigvis faktisk nyttig
Det er masse kode i OW4 som er nesten uforståelig fordi alt går via one-time-use helpers som gjør det utrolig tungvindt å skjønne hva som faktisk skjer og hvilke data og slik som hentes ut https://github.com/dotkom/onlineweb4/blob/main/apps/payment/mommy.py
Quality Gate passedIssues Measures |
This PR updates mark rules in accordance to https://old.online.ntnu.no/wiki/komiteer/nyeprikkregler/