Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docs for HttpClient.PatchAsync #2426

Merged
merged 3 commits into from
May 10, 2019
Merged

Add missing docs for HttpClient.PatchAsync #2426

merged 3 commits into from
May 10, 2019

Conversation

dsychin
Copy link
Contributor

@dsychin dsychin commented May 9, 2019

Fixes #1172

Added missing documentation.
Also added missing VB member signature.

@dsychin dsychin requested a review from karelz as a code owner May 9, 2019 15:22
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting the PatchAsync overloads. I've made a number of suggestions. The most important of these is that the member summary for each overload should make it easily distinguishable from the other overloads.

xml/System.Net.Http/HttpClient.xml Outdated Show resolved Hide resolved
xml/System.Net.Http/HttpClient.xml Outdated Show resolved Hide resolved
xml/System.Net.Http/HttpClient.xml Outdated Show resolved Hide resolved
xml/System.Net.Http/HttpClient.xml Outdated Show resolved Hide resolved
@mairaw mairaw added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label May 10, 2019
@mairaw mairaw added this to the May 2019 milestone May 10, 2019
@mairaw
Copy link
Contributor

mairaw commented May 10, 2019

The missing VB.NET signature fix might disappear next time we run reflection.
We have a tracking bug for this on the mdoc tool:
mono/api-doc-tools#356

@rpetrusha
Copy link

Thanks for making the additional changes, @dsychin. I'll merge your PR now. The new documentation should be live on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit 4b1d8e6 into dotnet:master May 10, 2019
@dsychin dsychin deleted the patch-async branch May 11, 2019 01:32
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing .net core docs
3 participants