Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VB.NET signatures #3721

Merged
merged 2 commits into from
Dec 31, 2019
Merged

Add VB.NET signatures #3721

merged 2 commits into from
Dec 31, 2019

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 28, 2019

@mairaw, May you check in the staging site if this solves #3720 ?

Fixes #3720

@dotnet-bot dotnet-bot added this to the December 2019 milestone Dec 28, 2019
@gewarren
Copy link
Contributor

@mairaw, May you check in the staging site if this solves #3720 ?

Yes, it does.

image

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple typos. Thanks for adding these.

xml/System.Web.UI/ScriptManager.xml Outdated Show resolved Hide resolved
xml/System.Web.UI/ScriptManager.xml Outdated Show resolved Hide resolved
Co-Authored-By: Genevieve Warren <[email protected]>
@gewarren gewarren merged commit 8913485 into dotnet:master Dec 31, 2019
@Youssef1313 Youssef1313 deleted the patch-2 branch December 31, 2019 18:13
@mairaw
Copy link
Contributor

mairaw commented Jan 9, 2020

Just FYI this will be undone every time we run CI since this information is automatically generated. This issue will need to be fixed: mono/api-doc-tools#356

@Youssef1313
Copy link
Member Author

Is the reason of the missing information known ?

@mairaw
Copy link
Contributor

mairaw commented Jan 28, 2020

I don't know @Youssef1313. This would be a question for @joelmartinez.

@joelmartinez
Copy link
Contributor

@Youssef1313 the tool which generates these signatures from compiled assemblies (which @mairaw linked to the relevant repo/issue) needs to be updated. It's on my team's list, we just need to get through a few other high priority tasks before we get there :) Once that issue is resolved, the missing VB.NET signatures will be systematically added (just as Maira mentioned, they will currently be systematically removed by the tool as they are regenerated every time API discovery is run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VB isn't displayed in language selector
5 participants