-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VB.NET signatures #3721
Add VB.NET signatures #3721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple typos. Thanks for adding these.
Co-Authored-By: Genevieve Warren <[email protected]>
Just FYI this will be undone every time we run CI since this information is automatically generated. This issue will need to be fixed: mono/api-doc-tools#356 |
Is the reason of the missing information known ? |
I don't know @Youssef1313. This would be a question for @joelmartinez. |
@Youssef1313 the tool which generates these signatures from compiled assemblies (which @mairaw linked to the relevant repo/issue) needs to be updated. It's on my team's list, we just need to get through a few other high priority tasks before we get there :) Once that issue is resolved, the missing VB.NET signatures will be systematically added (just as Maira mentioned, they will currently be systematically removed by the tool as they are regenerated every time API discovery is run) |
@mairaw, May you check in the staging site if this solves #3720 ?
Fixes #3720