also add the child nodes partition distances to the workspace for tri…

…ggering on node reuse
douira · Dec 15, 2023 · 90c3632 · 90c3632
1 parent cccb206
commit 90c3632
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/.../sodium/client/render/chunk/translucent_sorting/bsp_tree/InnerBinaryPartitionBSPNode.java b/.../sodium/client/render/chunk/translucent_sorting/bsp_tree/InnerBinaryPartitionBSPNode.java
@@ -24,6 +24,14 @@ class InnerBinaryPartitionBSPNode extends InnerPartitionBSPNode {
     @Override
     void addPartitionPlanes(BSPWorkspace workspace) {
         workspace.addAlignedPartitionPlane(this.axis, this.planeDistance);
+
+        // also add the planes of the children
+        if (this.inside instanceof InnerPartitionBSPNode inside) {
+            inside.addPartitionPlanes(workspace);
+        }
+        if (this.outside instanceof InnerPartitionBSPNode outside) {
+            outside.addPartitionPlanes(workspace);
+        }
     }
 
     private void collectInside(BSPSortState sortState, Vector3fc cameraPos) {

diff --git a/...s/sodium/client/render/chunk/translucent_sorting/bsp_tree/InnerMultiPartitionBSPNode.java b/...s/sodium/client/render/chunk/translucent_sorting/bsp_tree/InnerMultiPartitionBSPNode.java
@@ -29,6 +29,13 @@ void addPartitionPlanes(BSPWorkspace workspace) {
         for (int i = 0; i < this.planeDistances.length; i++) {
             workspace.addAlignedPartitionPlane(this.axis, this.planeDistances[i]);
         }
+
+        // recurse on children to also add their planes
+        for (var partition : this.partitions) {
+            if (partition instanceof InnerPartitionBSPNode inner) {
+                inner.addPartitionPlanes(workspace);
+            }
+        }
     }
 
     private void collectPlaneQuads(BSPSortState sortState, int planeIndex) {