Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebView state restoration feature #2666

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Jan 21, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209202305408189/f

Description

Adds a feature allowing to control the ability in iOS app to persist WebView interaction state (back/forward navigation stack, scroll position) to be able to restore it after app was terminated.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Reference

Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Tue, 21 Jan 2025 11:37:04 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (12 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -10959,8 +10959,12 @@
                     }
                 ]
             }
         },
+        "webViewStateRestoration": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "webViewBlobDownload": {
             "exceptions": [],
             "state": "disabled"
         },
v3/ios-config.json
--- v3/ios-config.json
+++ v3/ios-config.json
@@ -11296,8 +11296,12 @@
                     }
                 ]
             }
         },
+        "webViewStateRestoration": {
+            "state": "enabled",
+            "exceptions": []
+        },
         "webViewBlobDownload": {
             "exceptions": [],
             "state": "disabled"
         },
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -9968,8 +9968,12 @@
                     }
                 ]
             }
         },
+        "webViewStateRestoration": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "webViewBlobDownload": {
             "exceptions": [],
             "state": "disabled"
         },
v4/ios-config.json
--- v4/ios-config.json
+++ v4/ios-config.json
@@ -10264,8 +10264,12 @@
                     }
                 ]
             }
         },
+        "webViewStateRestoration": {
+            "state": "enabled",
+            "exceptions": []
+        },
         "webViewBlobDownload": {
             "exceptions": [],
             "state": "disabled"
         },

@dus7 dus7 marked this pull request as ready for review January 21, 2025 12:45
@dus7 dus7 requested review from a team as code owners January 21, 2025 12:45
@dus7 dus7 requested a review from graeme January 21, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants