Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unterminated string initialization for hexchar #1030

Merged

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Jan 20, 2025

gcc v15+ (used in fedora rawhide at this time) will add the check for unterminated string initialization as a default, thus causing the build to fail due to the hexchar function. Since this function uses the char array only for mapping an integer to a hexadecimal char, this error can be ignored.

gcc v15+ will add the check for unterminated string initialization
as a default, thus causing the build to fail due to the hexchar
function. Since this function uses the char array only for mapping
an integer to a hexadecimal char, this error can be ignored.

Signed-off-by: Michael Engel <[email protected]>
@engelmi engelmi force-pushed the fix-unterminated-string-initialization branch from 1af34e8 to d43fab8 Compare January 20, 2025 15:23
@coveralls
Copy link

coveralls commented Jan 20, 2025

Coverage Status

coverage: 82.251% (-0.1%) from 82.354%
when pulling d43fab8 on engelmi:fix-unterminated-string-initialization
into 5bc1b9a on eclipse-bluechi:main.

Copy link
Contributor

@ArtiomDivak ArtiomDivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 4decef2 into eclipse-bluechi:main Jan 20, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants