Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven group id to match the actual deployment #738

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

merks
Copy link
Contributor

@merks merks commented Jan 12, 2025

Fix the remaining bundles not addressed by the previous commit.

#737

Fix the remaining bundles not addressed by the previous commit.

eclipse-equinox#737
@merks
Copy link
Contributor Author

merks commented Jan 12, 2025

Another one of Oomph's handy dandy tools builds an overview of all the POMs in a folder location and with that it's easy to see if any are using an inappropriate group ID:

image

This helps to easily find ones that still needed fixing. (Of course the group ID only matters for bundles.)

@laeubi
Copy link
Member

laeubi commented Jan 12, 2025

Thanks, I missed that ones because I assumed they are all pomless already!

Copy link

Test Results

  666 files  ±0    666 suites  ±0   1h 18m 29s ⏱️ + 3m 45s
2 217 tests ±0  2 170 ✅ ±0   47 💤 ±0  0 ❌ ±0 
6 795 runs  ±0  6 652 ✅ ±0  143 💤 ±0  0 ❌ ±0 

Results for commit 14bab36. ± Comparison against base commit cdb5cbc.

@merks
Copy link
Contributor Author

merks commented Jan 12, 2025

I believe that one TCK always fails.

@merks merks merged commit 5299f50 into eclipse-equinox:master Jan 12, 2025
26 of 27 checks passed
@merks merks deleted the pr-group-id branch January 12, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants