Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2301 Windows 32 bit fixes #2404

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 7, 2025

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (e088257) to head (85a9726).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   78.69%   78.70%           
=======================================
  Files         440      440           
  Lines       16981    16981           
  Branches     2361     2361           
=======================================
+ Hits        13364    13365    +1     
  Misses       2736     2736           
+ Partials      881      880    -1     
Flag Coverage Δ
unittests 78.50% <ø> (+<0.01%) ⬆️
unittests_timing 15.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-2301-windows-32-bit-fixes branch from 85a9726 to 6466721 Compare January 7, 2025 18:34
@elBoberido elBoberido requested a review from elfenpiff January 7, 2025 18:35
@elBoberido elBoberido force-pushed the iox-2301-windows-32-bit-fixes branch from 6466721 to 8973e18 Compare January 7, 2025 18:42
@@ -81,6 +84,9 @@ cmake -S iceoryx_meta -B build-64 -DCMAKE_BUILD_TYPE=Release -DEXAMPLES=ON -DIOX
cmake --build build-64
```

> [!NOTE]
> On Windows with MSVC, there is now counterpart for `-malign-double` and therefore the 32-64 bit mix-mode does not yet work on Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no counterpart

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not as flag but it seems we are lucky and MSVC puts at least atomics on 8 byte boundaries

@elBoberido elBoberido merged commit f6e2a98 into eclipse-iceoryx:main Jan 7, 2025
21 checks passed
@elBoberido elBoberido deleted the iox-2301-windows-32-bit-fixes branch January 7, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants