-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2301 Windows 32 bit fixes #2404
iox-#2301 Windows 32 bit fixes #2404
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2404 +/- ##
=======================================
Coverage 78.69% 78.70%
=======================================
Files 440 440
Lines 16981 16981
Branches 2361 2361
=======================================
+ Hits 13364 13365 +1
Misses 2736 2736
+ Partials 881 880 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
85a9726
to
6466721
Compare
6466721
to
8973e18
Compare
@@ -81,6 +84,9 @@ cmake -S iceoryx_meta -B build-64 -DCMAKE_BUILD_TYPE=Release -DEXAMPLES=ON -DIOX | |||
cmake --build build-64 | |||
``` | |||
|
|||
> [!NOTE] | |||
> On Windows with MSVC, there is now counterpart for `-malign-double` and therefore the 32-64 bit mix-mode does not yet work on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no counterpart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not as flag but it seems we are lucky and MSVC puts at least atomics on 8 byte boundaries
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References