-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#846 Reduce undefs in platform correction header #2407
Merged
elBoberido
merged 5 commits into
eclipse-iceoryx:main
from
elBoberido:iox-846-reduce-undefs-in-platform-correction-header
Jan 10, 2025
Merged
iox-#846 Reduce undefs in platform correction header #2407
elBoberido
merged 5 commits into
eclipse-iceoryx:main
from
elBoberido:iox-846-reduce-undefs-in-platform-correction-header
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
commented
Jan 8, 2025
iceoryx_platform/win/include/iceoryx_platform/platform_correction.hpp
Outdated
Show resolved
Hide resolved
elBoberido
force-pushed
the
iox-846-reduce-undefs-in-platform-correction-header
branch
from
January 8, 2025 23:35
9e47529
to
34f7c36
Compare
elfenpiff
approved these changes
Jan 10, 2025
elBoberido
deleted the
iox-846-reduce-undefs-in-platform-correction-header
branch
January 10, 2025 14:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References