Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

354734 Update jackson to 2.16, adapt to behavioral changes #807

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

paolobazzi
Copy link
Member

(1) Jackson adapted handling for Optional serialization providing a custom exception message if Optional is being serialized. Scout does not support serialization of Java Optional, therefore adapt test case. See also:
FasterXML/jackson-databind#4082 FasterXML/jackson-databind@d7e77c3

(2) Jackson adapted handling for untyped deserialization of floating point numbers. Former implementations (before 2.15) deserialized floating point numbers within lists as BigDecimal. Since issue 903 and 3751 numbers are deserialized into the smalles possible Java data type (same behavior as plain numbers not within a JSON list element). Therefore Scout DoCollectionDeserializer was adapted identically to DoEntityDeserializer to enforce using BigDecimal for unknown (raw) number deserialization.

See also:
FasterXML/jackson-core#903 FasterXML/jackson-core@4c957e3 and
FasterXML/jackson-databind#3751 FasterXML/jackson-databind@23ea48c

@paolobazzi paolobazzi self-assigned this Dec 1, 2023
@paolobazzi paolobazzi force-pushed the features/pbz/24.1/354734-jackson-2.16 branch from 4e7de66 to fb1cd28 Compare December 1, 2023 15:57
@paolobazzi paolobazzi force-pushed the features/pbz/24.1/354734-jackson-2.16 branch 2 times, most recently from 83dee19 to e76baf3 Compare December 4, 2023 19:55
(1) Jackson adapted handling for Optional serialization providing a
custom exception message if Optional is being serialized. Scout does not
support serialization of Java Optional, therefore adapt test case.
See also:
FasterXML/jackson-databind#4082
FasterXML/jackson-databind@d7e77c3

(2) Jackson adapted handling for untyped deserialization of floating
point numbers. Former implementations (before 2.15) deserialized
floating point numbers within lists as BigDecimal. Since issue 903 and
3751 numbers are deserialized into the smalles possible Java data type
(same behavior as plain numbers not within a JSON list element).
Therefore Scout DoCollectionDeserializer was adapted identically to
DoEntityDeserializer to enforce using BigDecimal for unknown (raw)
number deserialization.

See also:
FasterXML/jackson-core#903
FasterXML/jackson-core@4c957e3
and
FasterXML/jackson-databind#3751
FasterXML/jackson-databind@23ea48c

354734
@paolobazzi paolobazzi force-pushed the features/pbz/24.1/354734-jackson-2.16 branch from e76baf3 to b8b8ad2 Compare December 5, 2023 07:33
@paolobazzi
Copy link
Member Author

run tests

@paolobazzi paolobazzi merged commit 6fb6ee9 into releases/24.1 Dec 6, 2023
@paolobazzi paolobazzi deleted the features/pbz/24.1/354734-jackson-2.16 branch December 6, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants