Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save creating (and validating) a peer INET address if not required #4928

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

franz1981
Copy link
Contributor

This is the twin of #4927

@franz1981
Copy link
Contributor Author

franz1981 commented Nov 2, 2023

in order to make this more effective I should change EndpointKey too and NOT enforce non-null peer address, to allow it to be null if ssl is disabled; while right now peerAddr should always be non null:

  EndpointKey(boolean ssl, ProxyOptions proxyOptions, SocketAddress serverAddr, SocketAddress peerAddr) {
    if (serverAddr == null) {
      throw new NullPointerException("No null server address");
    }
    if (peerAddr == null) {
      throw new NullPointerException("No null peer address");
    }
    this.ssl = ssl;
    this.proxyOptions = proxyOptions;
    this.peerAddr = peerAddr;
    this.serverAddr = serverAddr;
  }

let me know if I can proceed and push this forward till than

@vietj vietj merged commit d8f4e82 into eclipse-vertx:4.x Nov 2, 2023
6 checks passed
@vietj vietj added this to the 4.5.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants