Support duplicated context duplication #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@franz1981 @cescoffier please have a look |
|
This can be related (and better used at) quarkusio/quarkus#40725 can you checkout my branch there and show how the changes there will translate with the new API, bud? I'm travelling, but I would like, before it got merged, to make sure the semantic and behaviours won't change too much and instead we save some code by leveraging this new feature (which is super cool!) |
|
for now this is a tentative PR, we can discuss next week @franz1981 I think |
|
Yep, let's sync once I'm back, thanks @vietj 🙏 |
franz1981
reviewed
May 30, 2024
franz1981
reviewed
May 30, 2024
vietj
force-pushed
the
context-local-nested-duplicate
branch
from
ace4b39 to
dc2f1fb
Compare
|
See #5437 |
vietj
force-pushed
the
context-local-nested-duplicate
branch
from
dc2f1fb to
a83ead8
Compare
Motivation: Duplicating a duplicated context is supported but the duplication semantic is not defined. Changes: This update the duplicated context duplication by doing a copy of each local in the duplicated duplicate. This introduce a duplicator for each local that is responsible for copying the object when it is not null.
vietj
force-pushed
the
context-local-nested-duplicate
branch
from
a83ead8 to
c6d4c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicating a duplicated context is supported but the semantic of the actual locals is not defined.
This update the duplicated context duplication by doing a copy of each local in the duplicated duplicate. This introduce a duplicator for each local that is responsible for copying the object when it is not null.