Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/clang format #69

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix/clang format #69

wants to merge 2 commits into from

Conversation

tbkr
Copy link

@tbkr tbkr commented Jan 16, 2025

Removed duplicate keys from clang-format file.

This lead to clang-tidy using LLVM default als fallback.

@FussyDuck
Copy link

FussyDuck commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

@tbkr tbkr changed the base branch from master to develop January 16, 2025 18:38
@tbkr tbkr requested a review from Ozaq January 16, 2025 18:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 34.33476% with 765 lines in your changes missing coverage. Please review.

Project coverage is 49.73%. Comparing base (1336a19) to head (a53d6dd).

Files with missing lines Patch % Lines
src/fdb5/remote/Messages.cc 0.00% 86 Missing ⚠️
src/fdb5/remote/client/ClientConnection.cc 0.00% 54 Missing ⚠️
src/fdb5/remote/client/RemoteCatalogue.cc 0.00% 53 Missing ⚠️
src/fdb5/remote/client/RemoteStore.cc 0.00% 43 Missing ⚠️
src/fdb5/remote/server/CatalogueHandler.cc 0.00% 37 Missing ⚠️
src/fdb5/api/RemoteFDB.cc 0.00% 31 Missing ⚠️
src/fdb5/database/Manager.cc 30.00% 21 Missing ⚠️
src/fdb5/remote/FdbServer.cc 0.00% 20 Missing ⚠️
src/fdb5/remote/server/AvailablePortList.cc 0.00% 20 Missing ⚠️
src/fdb5/message/MessageArchiver.cc 0.00% 19 Missing ⚠️
... and 78 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #69       +/-   ##
============================================
- Coverage    61.21%   49.73%   -11.48%     
============================================
  Files          265      260        -5     
  Lines        14935    14170      -765     
  Branches      1474     1446       -28     
============================================
- Hits          9142     7048     -2094     
- Misses        5793     7122     +1329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants