-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Base64-encoded output of key and/or payload data #206
base: master
Are you sure you want to change the base?
Conversation
Here's a first cut at base64 support using a derivative of Jouni Malinen's base64 implementation. I started from PR #164, but it's diverged almost completely since then. A few notes:
|
👍 for this feature |
Hi @jjlin - what's the current status of you work? I'm planning to build kafkacat using your branch to move some binary data. Is there anything I need to be aware of? It would be great if the |
@wojtek-oledzki AFAIK, the base64-encoding functionality works fine, and I'm using it myself. |
@jjlin how do you import data back to Kafka when exported with -S base64? |
@wojtek-oledzki To clarify what I said about "the producer is not set up for handling this yet", the |
I also needed the producer mode and created a PR for that: jjlin#1 |
@edenhill Following up since it's been a few months. What would it take to get this merged? Is there anything you want changed in the overall approach? |
It would be great to have this PR integrated asap. I see that PR also adds base64 to -J which is great. RIght now -J is broken with binary data since it assumes that data is in UTF-8 |
@edenhill May we get your thoughts on this PR? kafkacat is a great tool, however its current limitation to non-binary data prevents us from using it. Of the kafkacat PRs for base64 output that I have seen, this is the one I like most, because it can also encode the keys. |
Also includes some refactoring of Avro-related code and minor doc fixes.
hi @edenhill could you please review/respond to this PR? This feature would be very useful. If the project is dead (as asked in #424) at least make it official so people can readjust. I'm willing to make a small donation to the project if that is helpful, I get that OSS maintenance requires time and effort. |
Also includes some refactoring of Avro-related code and minor doc fixes.