Move XML declaration to start of file for sky130.lym #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTimothyEdwards
approved these changes
Apr 9, 2024
|
@donn : I want to merge this but I also want to know why there are 35 failing regression test checks and why they are occurring. |
|
That would be good to know indeed! The CI is from Mabrains, so maybe Amro Tork knows more. We can open an issue about it and merge this PR in the meantime, since it does not affect the CI. |
|
Opened: #16 |
|
Hi, I'm on vacation- I had nothing to do with this CI, so. All I did to this repo is move the XML headers to the beginning of the documents so later versions of KLayout stopped crashing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the XML declaration to the beginning of the file to make it valid.
Similar to #12, but it seems this file has been forgotten as it is not read when using OpenLane.