Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dispatch-router #15

Open
wants to merge 1 commit into
base: podify
Choose a base branch
from
Open

Add dispatch-router #15

wants to merge 1 commit into from

Conversation

ehelms
Copy link
Owner

@ehelms ehelms commented Mar 28, 2018

No description provided.

boaz0
boaz0 reviewed Apr 30, 2018
View reviewed changes
Copy link

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boaz0
Copy link

boaz0 commented Apr 30, 2018

@ehelms there is a merge-conflict, can you rebase... otherwise LGTM.

@ehelms
Copy link
Owner Author

ehelms commented Apr 30, 2018

Thanks for the review @ripcurld -- this needs to be re-opened against Forklift master once we merge in this branch. Also have to solve how to expose this externally which is the real crux of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boaz0 boaz0 boaz0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @boaz0