Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the document title to the current call name. #2928

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Set the document title to the current call name. #2928

merged 3 commits into from
Jan 8, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Jan 6, 2025 •
edited
Loading

nearly f1xes #270

The final version to fix #270 needs more design thought

@Half-Shot Half-Shot requested a review from a team as a code owner January 6, 2025 16:08
@Half-Shot Half-Shot requested a review from hughns January 6, 2025 16:08
hughns
hughns reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced issue (#270) also wanted the ordering of the title changed so that the call name appears leftmost. Did you intend to do this too?

@Half-Shot
Copy link
Member Author

The referenced issue (#270) also wanted the ordering of the title changed so that the call name appears leftmost. Did you intend to do this too?

I'll do a design check first on this, since it's a bit of a change.

@hughns hughns merged commit 7e507d6 into livekit Jan 8, 2025
7 checks passed
@hughns hughns deleted the hs/set-page-title branch January 8, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughns hughns hughns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve page title on calls
2 participants
@Half-Shot @hughns