Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portal.getComponent is missing path in fragment preview #10116 #10859

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ashklianko
Copy link
Member

  • A component is supposed to always have some path, but in case of a fragment content it's root fragment component was having null returned as path. Fixing it by setting component's path to "/" in case it doesn't have a region (which means it is a fragment)

@ashklianko ashklianko requested a review from rymsha January 14, 2025 12:41
@ashklianko ashklianko linked an issue Jan 14, 2025 that may be closed by this pull request
- A component is supposed to always have some path, but in case of a fragment content it's root fragment component was having null returned as path. Fixing it by setting component's path to "/" in case it doesn't have a region (which means it is a fragment)
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (d8f1227) to head (c82c943).
Report is 2 commits behind head on 7.15.

Additional details and impacted files
@@            Coverage Diff            @@
##               7.15   #10859   +/-   ##
=========================================
  Coverage     84.49%   84.49%           
+ Complexity    19613    19612    -1     
=========================================
  Files          2608     2608           
  Lines         68350    68350           
  Branches       5446     5445    -1     
=========================================
  Hits          57755    57755           
  Misses         7952     7952           
  Partials       2643     2643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rymsha rymsha merged commit 1510dd3 into 7.15 Jan 14, 2025
5 checks passed
@rymsha rymsha deleted the issue-10116 branch January 14, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

portal.getComponent is missing path in fragment preview
2 participants