dont reset replicas when hpa is set (#5021)

dont reset deployment replicas when hpa is set This is no longer needed after #2816 was merged Relates to #4983 (comment) Signed-off-by: Arko Dasgupta <[email protected]>
envoyproxy · Jan 9, 2025 · 6466ceb · 6466ceb
1 parent 5427854
commit 6466ceb
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/internal/infrastructure/kubernetes/proxy/resource_provider.go b/internal/infrastructure/kubernetes/proxy/resource_provider.go
@@ -340,13 +340,6 @@ func (r *ResourceRender) Deployment() (*appsv1.Deployment, error) {
 		deployment.ObjectMeta.Name = r.Name()
 	}
 
-	provider := proxyConfig.GetEnvoyProxyProvider()
-
-	// omit the deployment replicas if HPA is being set
-	if provider.GetEnvoyProxyKubeProvider().EnvoyHpa != nil {
-		deployment.Spec.Replicas = nil
-	}
-
 	// apply merge patch to deployment
 	if deployment, err = deploymentConfig.ApplyMergePatch(deployment); err != nil {
 		return nil, err

diff --git a/internal/infrastructure/kubernetes/ratelimit/resource_provider.go b/internal/infrastructure/kubernetes/ratelimit/resource_provider.go
@@ -290,11 +290,6 @@ func (r *ResourceRender) Deployment() (*appsv1.Deployment, error) {
 		}
 	}
 
-	// omit the deployment replicas if HPA is being set
-	if r.rateLimitHpa != nil {
-		deployment.Spec.Replicas = nil
-	}
-
 	// apply merge patch to deployment
 	var err error
 	if deployment, err = r.rateLimitDeployment.ApplyMergePatch(deployment); err != nil {