-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add doc preview action #5057
base: main
Are you sure you want to change the base?
Conversation
uses: JamesIves/github-pages-deploy-action@v4 | ||
with: | ||
folder: gateway_docs_artifact | ||
repository-name: zirain/eg-pr-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use any repo to do this, use my personal one for POC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use gh-pages
branch instead of another repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, we need to an PAT which can force push to this repo, it's unsafe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5057 +/- ##
==========================================
- Coverage 66.84% 66.83% -0.02%
==========================================
Files 211 211
Lines 32920 32920
==========================================
- Hits 22007 22001 -6
- Misses 9586 9592 +6
Partials 1327 1327 ☔ View full report in Codecov by Sentry. |
e5f3e32
to
4ecc065
Compare
Signed-off-by: zirain <[email protected]>
4ecc065
to
7b45d8c
Compare
No description provided.