Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add doc preview action #5057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zirain
Copy link
Member

@zirain zirain commented Jan 14, 2025

No description provided.

@zirain zirain requested a review from a team as a code owner January 14, 2025 12:47
uses: JamesIves/github-pages-deploy-action@v4
with:
folder: gateway_docs_artifact
repository-name: zirain/eg-pr-preview
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use any repo to do this, use my personal one for POC.

Copy link
Member

@zhaohuabing zhaohuabing Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use gh-pages branch instead of another repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, we need to an PAT which can force push to this repo, it's unsafe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.83%. Comparing base (c499b41) to head (7b45d8c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5057      +/-   ##
==========================================
- Coverage   66.84%   66.83%   -0.02%     
==========================================
  Files         211      211              
  Lines       32920    32920              
==========================================
- Hits        22007    22001       -6     
- Misses       9586     9592       +6     
  Partials     1327     1327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain force-pushed the test-docs-preview branch 2 times, most recently from e5f3e32 to 4ecc065 Compare January 15, 2025 05:46
@zirain zirain force-pushed the test-docs-preview branch from 4ecc065 to 7b45d8c Compare January 17, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants