xds: move ready to dynamic listener

[zirain]

fixes: #2810

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 66.86%. Comparing base (7813ef0) to head (2a5a127).

Files with missing lines	Patch %	Lines
internal/gatewayapi/listener.go	60.00%	11 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5079      +/-   ##
==========================================
- Coverage   66.93%   66.86%   -0.08%     
==========================================
  Files         210      211       +1     
  Lines       32984    33228     +244     
==========================================
+ Hits        22079    22217     +138     
- Misses       9570     9655      +85     
- Partials     1335     1356      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zirain]

wait #5117

[arkodg]

should we delete fields no longer used ?

[zirain]

I recall I addressed this with a TODO for following refactor.

[guydc]

Do we want to maybe keep prom stats in bootstrap config and serve readiness on a different port to avoid breaking scraping?
I think that metrics have some value even if the proxy is not ready, e.g. they can reveal issues in the proxy subscribing for XDS with EG, handling the bootstrap config, etc.

[zirain]

Do we want to maybe keep prom stats in bootstrap config and serve readiness on a different port to avoid breaking scraping? I think that metrics have some value even if the proxy is not ready, e.g. they can reveal issues in the proxy subscribing for XDS with EG, handling the bootstrap config, etc.

IIUC, now they share the listener.