-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translator): use SDS to deliver system trust store to support dynamic reload #5084
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Guy Daich <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5084 +/- ##
==========================================
- Coverage 66.93% 66.92% -0.02%
==========================================
Files 210 210
Lines 32984 32968 -16
==========================================
- Hits 22079 22064 -15
- Misses 9570 9572 +2
+ Partials 1335 1332 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Guy Daich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
would be good to optimize this in the future to have 1 system secret rather than 1 per policy
Signed-off-by: Guy Daich <[email protected]>
cc @arkodg |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5074
Release Notes: Yes