Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): use SDS to deliver system trust store to support dynamic reload #5084

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Jan 17, 2025

What type of PR is this?

What this PR does / why we need it:

  • use SDS to deliver system trust store to support dynamic reload
  • Add e2e test

Which issue(s) this PR fixes:

Fixes #5074

Release Notes: Yes

@guydc guydc requested a review from a team as a code owner January 17, 2025 00:28
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.92%. Comparing base (7813ef0) to head (3ecc185).

Files with missing lines Patch % Lines
internal/xds/translator/translator.go 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5084      +/-   ##
==========================================
- Coverage   66.93%   66.92%   -0.02%     
==========================================
  Files         210      210              
  Lines       32984    32968      -16     
==========================================
- Hits        22079    22064      -15     
- Misses       9570     9572       +2     
+ Partials     1335     1332       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Jan 17, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
would be good to optimize this in the future to have 1 system secret rather than 1 per policy

@arkodg arkodg requested review from a team January 17, 2025 21:02
@arkodg arkodg added this to the v1.3.0 milestone Jan 21, 2025
@guydc guydc modified the milestones: v1.3.0, v1.3.0-rc.1 Jan 22, 2025
@guydc
Copy link
Contributor Author

guydc commented Jan 22, 2025

cc @arkodg
changed milestone to RC, as this is a behavior change and not a bug fix.

@arkodg arkodg requested review from a team January 23, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rotation of System WellKnownCACertificates in BTLSP
2 participants