Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(soft_spi_master_main.c): remove dead code #15119

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jurstu
Copy link
Contributor

@jurstu jurstu commented Jan 1, 2025

Description

Just removing a line that is no longer required. It seems to had been copy-pasted from dedicated_gpio/soft_uart example. It isn't found anywhere in the code for SPI example.

Related

Testing

Did a ctrl+f for any use of the define in code. Nothing appeared in SPI example, 1 use appeared in UART example (buffer length definition)

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass. // this has gotta be checked after I submit a PR
  • Documentation is updated as needed. // no need
  • Tests are updated or added as necessary. // no need
  • Code is well-commented, especially in complex areas. // guess so..
  • Git history is clean — commits are squashed to the minimum necessary. // yes

@CLAassistant
Copy link

CLAassistant commented Jan 1, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jan 1, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update soft_spi_master_main.c":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello jurstu, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 7eaf7f9

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 1, 2025
@github-actions github-actions bot changed the title Removal of unnecessary define Removal of unnecessary define (IDFGH-14329) Jan 1, 2025
@jurstu jurstu changed the title Removal of unnecessary define (IDFGH-14329) refactor(remove dead code): soft_spi_master_main.c Jan 1, 2025
@jurstu jurstu changed the title refactor(remove dead code): soft_spi_master_main.c refactor(soft_spi_master_main.c): remove dead code Jan 1, 2025
@suda-morris
Copy link
Collaborator

sha=7eaf7f9ebe60373aa843531553ef58a726607225

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Jan 2, 2025
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Jan 2, 2025
@jurstu
Copy link
Contributor Author

jurstu commented Jan 5, 2025

Is there anything more required for this PR to go forward, or is it just waiting for being handled?

@suda-morris
Copy link
Collaborator

It'a always merged in our internal gitlab, still need some time to sync it to the github.

@espressif-bot espressif-bot merged commit 587351e into espressif:master Jan 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Status: In Progress Work is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants