-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(soft_spi_master_main.c): remove dead code #15119
Conversation
👋 Hello jurstu, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
sha=7eaf7f9ebe60373aa843531553ef58a726607225 |
Is there anything more required for this PR to go forward, or is it just waiting for being handled? |
It'a always merged in our internal gitlab, still need some time to sync it to the github. |
Description
Just removing a line that is no longer required. It seems to had been copy-pasted from dedicated_gpio/soft_uart example. It isn't found anywhere in the code for SPI example.
Related
Testing
Did a ctrl+f for any use of the define in code. Nothing appeared in SPI example, 1 use appeared in UART example (buffer length definition)
Checklist
Before submitting a Pull Request, please ensure the following: