fix(rmt): Use ESP_DRAM_LOGD instead of ESP_DRAM_LOGE for "buffer too small" prints (IDFGH-14447) #15223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using RF it is possible there is a lot of noise. The developer cannot control this noise. Noise could be very long and cause these prints to occur very often. If CONFIG_RMT_ISR_IRAM_SAFE is enabled these prints will be sent over the uart in ISR context. Each print will take a few milliseconds to send at 115200. The result is system instability because ISRs are blocked for long periods of time. Currently the only work around is to disable all logging or disable uart logging.
Since these are not real errors and occur all the time in noisy environments it would be better to use ESP_DRAM_LOGD instead of ESP_DRAM_LOGE.
Related
Testing
Verified prints no longer happen unless debug is enabled.
Verified system is stable when these prints aren't enabled.
Checklist
Before submitting a Pull Request, please ensure the following: