Added option to use datetime stamp during logging. (IDFGH-3855)

[Molorius]

Added option to use datetime stamp during logging.

Also changed log timestamp formatting to use unsigned int, allowing for smaller buffer.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Alvin1Zhang]

Thanks for your contribution.

[projectgus]

Hi @Molorius ,

Thanks for sending this. I have a couple of minor comments but the change looks very useful to me, look forward to integrating it.

[projectgus]

Relatively minor, but for ease of use suggest adding this as a "choice" so the choices become "Milliseconds Since Boot", "System Time", "System Date and Time"

(Means some of the macro guards in esp_log.h will need to be updated as well.)

[Molorius]

It is now another choice in the kconfig.

[projectgus]

The description of this function in esp_log.h needs to be updated to match

[Molorius]

Would you prefer changing the name of the function or splitting it into esp_log_system_timestamp and esp_log_system_datetimestamp? The xTaskGetSchedulerState portion would be put into a static function for use between both.

[projectgus]

@Molorius Good point! That is probably a cleaner solution, thank you for pointing it out.

However if it becomes less clean to implement in some way, I'm OK with the current implementation - it just needs to be noted in the header that it might return a date+time depending on config.

[Molorius]

I separated the datetime elements into a separate function and updated esp_log.h to match.

[projectgus]

Hi @Molorius ,

Thanks for being patient while I got back to you. This looks great to me, I've squashed the commits and pushed it into our internal review & merge queue. The PR will be updated once it has merged.

Angus

[projectgus]

As it happens, at the last minute we've decided to try and implement this in a different way. Rather than having to add a whole new function and kconfig item for each new format, we're going to try to find an easier way to customize the log timestamp.

You don't need to do anything, this PR will still be updated once this functionality is available.