Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bootloop if chip is unknown #7216

Closed
wants to merge 1 commit into from

Conversation

s-hadinger
Copy link
Contributor

In case the PSIRAM chip is unknown, return an error and disable PSRAM
instead of calling abort() and causing a bootloop.

In Tasmota, we provide pre-compiled firmwares and we try to make the generic work on as many chips as possible. We have now enabled PSRAM by default, but when the chip is unknown, it bootloops because of the call to abort().

I don't see any downside in returning an error instead and letting the chip boot without PSRAM, and give control to the software as to how it should handle it.

In case the PSIRAM chip is unknown, return an error and disable PSRAM
instead of calling abort() and causing a bootloop
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally labels Sep 22, 2022
@ginkgm
Copy link
Collaborator

ginkgm commented May 30, 2023

Hi @s-hadinger ,

Thanks for your contribution. We have a similar feature for this. Please enable SPIRAM_IGNORE_NOTFOUND in the menuconfig.

@ginkgm ginkgm closed this May 30, 2023
@ginkgm ginkgm reopened this May 30, 2023
@Indastri
Copy link
Collaborator

Indastri commented Sep 9, 2024

@ginkgm can we close this, since we have similar feature?

@suda-morris
Copy link
Collaborator

can close now thanks to 33c2637

@suda-morris suda-morris closed this Dec 6, 2024
@espressif-bot espressif-bot added Status: Opened Issue is new and removed Status: Opened Issue is new labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants