Avoid bootloop if chip is unknown #7216
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the PSIRAM chip is unknown, return an error and disable PSRAM
instead of calling abort() and causing a bootloop.
In Tasmota, we provide pre-compiled firmwares and we try to make the generic work on as many chips as possible. We have now enabled PSRAM by default, but when the chip is unknown, it bootloops because of the call to abort().
I don't see any downside in returning an error instead and letting the chip boot without PSRAM, and give control to the software as to how it should handle it.