DEVPROD-9181 cleanup subscriptions and unused functions #8651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malikchaya2
requested changes
Jan 23, 2025
| // IsGithubMergePatch returns true if the patch is from the GitHub merge queue. | ||
| func (p *Patch) IsGithubMergePatch() bool { | ||
| return p.GithubMergeData.HeadSHA != "" | ||
| return p.Alias == evergreen.CommitQueueAlias || p.GithubMergeData.HeadSHA != "" |
There was a problem hiding this comment.
Do we still have to keep evergreen.CommitQueueAlias? If yes, can we maybe rename it or add a comment explaining why we need to keep it?
| @@ -375,7 +375,7 @@ func (j *patchIntentProcessor) finishPatch(ctx context.Context, patchDoc *patch. | |||
| } | |||
|
|
|||
| if patchDoc.IsMergeQueuePatch() { | |||
| patchDoc.Description = model.MakeCommitQueueDescription(patchDoc.Patches, pref, patchedProject, patchDoc.IsGithubMergePatch(), patchDoc.GithubMergeData) | |||
| patchDoc.Description = model.MakeCommitQueueDescription(patchDoc.Patches, pref, patchedProject, patchDoc.IsMergeQueuePatch(), patchDoc.GithubMergeData) | |||
There was a problem hiding this comment.
Can we update the name of MakeCommitQueueDescription and remove the "githubMergePatch" bool and the commit queue logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-9181
Description
Remove subscriptions, unused graphql tests, improve documentation, and consolidate IsGithubMergePatch and IsMergeQueuePatch.
I expect this to be the last PR under this ticket! So if you find anything I miss, let me know. The last thing I found are for UI tests for which I split a ticket (DEVPROD-14383, DEVPROD-13843)
Testing
Existing tests
Documentation
Tweaked slightly but I think that Brian handled the bulk of it already