DEVPROD-1647 Add animation to details button when details menu items are changed. #424
Conversation
Passing run #4020 ↗︎
Details:
Review all test suite changes for PR #424 ↗︎ |
||||||||||||||||||||
Good call! |
I pushed up a fix that will prevent it from happening on production builds. Due to how react 18 renders things twice in dev mode the animation will only display on first render locally but shouldn't on a production build. (You can disable strict mode to test this) |
There was a problem hiding this comment.
Single line search in range selection isn't updating the details menu nor showing the animation. Those code changes can be made in a separate PR if you like.
I'm unable to figure out how to reset the search in range selection without opening the details menu. Is it possible?
| } from "./Toggles"; | ||
|
|
||
| interface DetailsMenuProps { | ||
| ["data-cy"]?: string; |
There was a problem hiding this comment.
| ["data-cy"]?: string; | |
| "data-cy"?: string; |
| expect(detailsButton).toHaveAttribute("data-variant", "primary"); | ||
| jest.runAllTimers(); | ||
| await waitFor(() => { | ||
| expect(detailsButton).toHaveAttribute("data-variant", "default"); |
There was a problem hiding this comment.
nit: add assertions for all 3 states. flash off -> flash on -> flash off
src/components/DetailsMenu/index.tsx
Outdated
| } | ||
| const DetailsMenu: React.FC<DetailsMenuProps> = ({ disabled, ...rest }) => { | ||
| const [lowerRange] = useQueryParam(QueryParams.LowerRange, 0); |
There was a problem hiding this comment.
| const [lowerRange] = useQueryParam(QueryParams.LowerRange, 0); | |
| const [lowerRange] = useQueryParam(QueryParams.LowerRange); |
We can open a ticket to update it if the flow doesn't make sense.
That is not possible. When we originally opened this pr the UX didn't make sense to reset the search range from the selection menu. It is why this pr exists so that users are made aware of the change in the details menu. |
DEVPROD-1647
Description
Adds an animation to the details menu item when ever the search range is changed.
Screenshots
Screen.Recording.2023-10-31.at.3.52.37.PM.mov
Testing