🩹 gas: use L1 gas oracle #1262
Merged
🩹 gas: use L1 gas oracle #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jgalat
force-pushed
the
fix/gas-estimations
branch
from
b3192be to
5cabf4c
Compare
sebipap
previously approved these changes
Oct 27, 2023
hooks/useEstimateGas.ts
Outdated
| args: [data], | ||
| }); | ||
| } else { | ||
| l1Gas = 5_555_555_555_55n; |
There was a problem hiding this comment.
where does this come from?
There was a problem hiding this comment.
the thousand separators are shifted
There was a problem hiding this comment.
The value is only used in case we don't have a request ready to do a gas estimation (for example, on initial render of the modal we don't have an input, so that's a missing argument). I ran some experiments and just ended up choosing this as a magic number.
jgalat
force-pushed
the
fix/gas-estimations
branch
from
5cabf4c to
5ddf563
Compare
jgalat
force-pushed
the
fix/gas-estimations
branch
from
0d82821 to
8ba496f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1250