Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ network: auto switch network on CTA #1364

Merged
merged 4 commits into from
May 13, 2024
Merged

✨ network: auto switch network on CTA #1364

merged 4 commits into from
May 13, 2024

Conversation

franm91
Copy link
Member

@franm91 franm91 commented Mar 21, 2024

No description provided.

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 8:43pm

@franm91 franm91 requested a review from cruzdanilo as a code owner March 25, 2024 14:38
Copy link
Contributor

@sebipap sebipap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. left a comment for a future improvement

const { isConnected, chain: displayNetwork, connect, impersonateActive, exitImpersonate } = useWeb3();
const { chain } = useNetwork();
const { switchNetworkAsync, isLoading } = useSwitchNetwork();
const { close } = useModal('rollover');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future improvement: to close any modal, we should be able to pass undefined. Although is not part of this PR change we should change this in the useModal hook in the future or at least add a TODO comment now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants