[eas-cli] [ENG-14629] Improve AppleID validation #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clears the AppleID received from the prompt See: https://linear.app/expo/issue/ENG-14629/improve-apple-id-input-validation
Adds tests for `resolveUserCredentialsAsync` function, including reading malformed AppleID from the prompt See: https://linear.app/expo/issue/ENG-14629/improve-apple-id-input-validation
Removed redundant expect() See: https://linear.app/expo/issue/ENG-14629/improve-apple-id-input-validation
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: -914 B (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
==========================================
+ Coverage 52.46% 52.59% +0.14%
==========================================
Files 584 584
Lines 22637 22638 +1
Branches 4467 4707 +240
==========================================
+ Hits 11874 11905 +31
+ Misses 10729 9805 -924
- Partials 34 928 +894 ☔ View full report in Codecov by Sentry. |
szdziedzic
reviewed
Jan 22, 2025
| type: 'text', | ||
| name: 'username', | ||
| message: `Apple ID:`, | ||
| validate: (val: string) => val !== '', | ||
| initial: lastAppleId ?? undefined, | ||
| }); | ||
| username = username.replace(/[\x00-\x1F]/gi, ''); |
There was a problem hiding this comment.
can you add a comment here about historical context and what intention stands behind this regex?
…-14629_improve_apple_id_validation
Added a comment with context for the change See: https://linear.app/expo/issue/ENG-14629/improve-apple-id-input-validation
Updated CHANGELOG.md See: https://linear.app/expo/issue/ENG-14629/improve-apple-id-input-validation
|
✅ Thank you for adding the changelog entry! |
szdziedzic
approved these changes
Jan 22, 2025
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-14629_improve_apple_id_validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-14629/improve-apple-id-input-validation
\u0017)How
The username value from prompt is cleared of any invalid unprintable characters before updating cache and using the value to log into Apple account
Test Plan
Added tests for
resolveUserCredentialsAsyncfunctionTested the behaviour for a username with reported invalid characters