-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add event category to Fantom.dispatchNativeEvent #48855
Open
sammy-SC
wants to merge
2
commits into
facebook:main
Choose a base branch
from
sammy-SC:export-D68413879
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+358
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Jan 22, 2025
This pull request was exported from Phabricator. Differential Revision: D68413879 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Jan 22, 2025
Summary: changelog: [internal] add event category argument to Fantom.dispatchNativeEvent. This gives tests option to control whether an event is continuous, discrete etc. Reviewed By: rubennorte Differential Revision: D68413879
sammy-SC
force-pushed
the
export-D68413879
branch
from
January 22, 2025 13:28
17ccd19
to
4b451c9
Compare
This pull request was exported from Phabricator. Differential Revision: D68413879 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Jan 22, 2025
Summary: changelog: [internal] add event category argument to Fantom.dispatchNativeEvent. This gives tests option to control whether an event is continuous, discrete etc. Reviewed By: rubennorte Differential Revision: D68413879
sammy-SC
force-pushed
the
export-D68413879
branch
from
January 22, 2025 16:31
4b451c9
to
51011d8
Compare
This pull request was exported from Phabricator. Differential Revision: D68413879 |
Summary: changelog: [internal] Add payload argument to Fantom.dispatchNativeEvent. For example, in `TextInput.onChange` event, new value of input field must be present in the event payload. Reviewed By: rubennorte Differential Revision: D68410469
Summary: changelog: [internal] add event category argument to Fantom.dispatchNativeEvent. This gives tests option to control whether an event is continuous, discrete etc. Reviewed By: rubennorte Differential Revision: D68413879
sammy-SC
force-pushed
the
export-D68413879
branch
from
January 22, 2025 16:48
51011d8
to
9d3d337
Compare
This pull request was exported from Phabricator. Differential Revision: D68413879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
add event category argument to Fantom.dispatchNativeEvent.
This gives tests option to control whether an event is continuous, discrete etc.
Reviewed By: rubennorte
Differential Revision: D68413879