Skip to content

Commit

Permalink
MoQClient call MoQSession::onSessionEnd
Browse files Browse the repository at this point in the history
Summary: This is the cue for the MoQSession to begin teardown.

Reviewed By: sharmafb

Differential Revision: D68136646

fbshipit-source-id: 96f93a613b58e7f36e212fa7db82cfe4551c125e
  • Loading branch information
afrind authored and facebook-github-bot committed Jan 14, 2025
1 parent 97d60b5 commit 10cc8db
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions moxygen/MoQClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,12 @@ void MoQClient::HTTPHandler::onError(
client_.onSessionEnd(folly::none);
}

void MoQClient::onSessionEnd(folly::Optional<uint32_t>) {
// TODO: cleanup?
XLOG(DBG1) << "resetting moqSession_";
auto moqSession = std::move(moqSession_);
moqSession.reset();
CHECK(!moqSession_);
void MoQClient::onSessionEnd(folly::Optional<uint32_t> err) {
if (moqSession_) {
moqSession_->onSessionEnd(err);
XLOG(DBG1) << "resetting moqSession_";
moqSession_.reset();
}
}

void MoQClient::onNewBidiStream(proxygen::WebTransport::BidiStreamHandle bidi) {
Expand Down

0 comments on commit 10cc8db

Please sign in to comment.