Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SECURITY.md for project security policy #315

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

KhaledAchech
Copy link
Contributor

Added a new security policy to the repository.

This pull request introduces a comprehensive security policy (SECURITY.md) to enhance the overall security posture of the project. The security policy outlines guidelines, procedures, and reporting mechanisms to address and respond to potential security vulnerabilities.

I've carefully followed the contributing guidelines, but if there are any adjustments or additional steps needed, please let me know. I appreciate your time and consideration.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7553ed) 88.90% compared to head (525a034) 88.88%.
Report is 11 commits behind head on develop.

❗ Current head 525a034 differs from pull request most recent head 8ac9784. Consider uploading reports for the commit 8ac9784 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
- Coverage    88.90%   88.88%   -0.02%     
===========================================
  Files           14       14              
  Lines         1226     1224       -2     
  Branches       177      177              
===========================================
- Hits          1090     1088       -2     
  Misses         123      123              
  Partials        13       13              
Flag Coverage Δ
unittests 88.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abompard
Copy link
Member

Could you please rebase, amend and force-push your commit? I've added a pre-commit check that will fix some formatting in the files.

@KhaledAchech
Copy link
Contributor Author

Could you please rebase, amend and force-push your commit? I've added a pre-commit check that will fix some formatting in the files.

Yes, definitely. That's awesome, can you share how to setup such tests that automatically fixes files formatting and if it's applicable share any learning resources for implementing integration tests ?

@KhaledAchech KhaledAchech force-pushed the issue#314-security-policy branch from 1a7f476 to 25df401 Compare December 14, 2023 08:50
@abompard
Copy link
Member

abompard commented Dec 14, 2023

That's awesome, can you share how to setup such tests that automatically fixes files formatting and if it's applicable share any learning resources for implementing integration tests ?

Yes of course, we're using pre-commit, and the .pre-commit-config.yaml file in the repo lists the tests that will be run before each commit. You can enable it in your clone by installing pre-commit (it's probably already available in your distribution) and running pre-commit install.

@abompard
Copy link
Member

In your case that would mean running git commit --amend after the pre-commit install step, so that pre-commit is triggerred on the existing content.

@KhaledAchech
Copy link
Contributor Author

In your case that would mean running git commit --amend after the pre-commit install step, so that pre-commit is triggerred on the existing content.

I understand, thanks for clearing that up :) I will make sure to get to it in the evening.

@KhaledAchech KhaledAchech force-pushed the issue#314-security-policy branch from 25df401 to 7d530f4 Compare December 15, 2023 10:56
@KhaledAchech
Copy link
Contributor Author

KhaledAchech commented Dec 15, 2023

I apologize for the inconvenience before.
I think now, things should be in order :) I cleaned my commits with a rebase and followed the pre-commit installation and then I executed the amend after that I executed the force push. Hopefully now everything in order, if not please let me know what needs to be changed and also thanks for your help and patience ^^

Edit: In my previous change I forgot to fix the actual problem which is the EOF in security.md && PR314.doc. Again, I'm sorry, I got a bit too hasty and distracted.

@KhaledAchech KhaledAchech force-pushed the issue#314-security-policy branch from 6dc7980 to 8ac9784 Compare December 15, 2023 14:52
@abompard abompard merged commit 01e55fd into fedora-infra:develop Dec 15, 2023
17 checks passed
@abompard
Copy link
Member

Thanks @KhaledAchech !

@KhaledAchech
Copy link
Contributor Author

Thanks @KhaledAchech !

Awesome! Thank you for all the help ^^

@gridhead gridhead mentioned this pull request Mar 7, 2024
@gridhead gridhead linked an issue Mar 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security policy question
3 participants