-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing support using VCR.py #78
Conversation
Also, moved out PyCharm related configuration to be considered by the Version Control System and added the testing schematic in the Tox configuration Signed-off-by: Akashdeep Dhar <[email protected]>
Signed-off-by: Akashdeep Dhar <[email protected]>
Signed-off-by: Akashdeep Dhar <[email protected]>
One of the previous test runs actually connected to GitLab.com to make testing HTTP API requests and used a lot of networking and computing resources while taking as long 3 minutes and 11 seconds to complete. As external services are used, the reliability of the testcases also depend on the services' health, network conditions etc. With the use of VCR.py, only those HTTP API requests are conveyed all the way up to GitLab.com that are required to test the functionality of cloning and transferring the repository assets. The responses to the majority of HTTP API requests are emulated in this test run and that brings down the time to as low as 1 minute and 14 seconds. That is approximately 61.25% time saved on test runs with significant improvement on the reliability of those! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looked intimidating when I saw +25,436 −137; but then I checked how smartly you added @pytest.mark.vcr(filter_headers=["Authorization"])
to the test cases that's why i checked in my review that it should be included in all the test cases!
Thanks for the review, @samyak-jn! |
Add testing support using VCR.py
Add testing support using VCR.py
Fixes #42