Feature: Display storage information for phones and tablets

[ferrariofilippo]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Closes Feature: Display smartphone/tablet storage size and free space #6872

Notes
I proposed two possible working solutions (one commented out):

• the first one performs a double check
• the second goes with only one check (which should be enough in most cases)

Tell me which one do you find more appropriate

Screenshots

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Open Files Home
2. Enable Drives widget
3. Connect a phone/tablet
4. Check that storage is shown
5. IMPORTANT: if you have the opportunity, test this feature using a phone with an SD card (may be source of bugs)

[yaira2]

Suggested change

	var propertiesSource = Root;
	if (string.IsNullOrEmpty(Root.Path) &&
	Path.StartsWith(@"\\?\", StringComparison.Ordinal) &&
	(await Root.GetFoldersAsync())[0] is StorageFolder systemFolder)
	{
	propertiesSource = systemFolder;
	}
	var propertiesSource = (string.IsNullOrEmpty(Root.Path) &&
	Path.StartsWith(@"\\?\", StringComparison.Ordinal) &&
	(await Root.GetFoldersAsync())[0] is StorageFolder systemFolder)
	? systemFolder
	: Root;

[yaira2]

IMPORTANT: if you have the opportunity, test this feature using a phone with an SD card (may be source of bugs)

This appears to be an issue because the widget only displays storage information for the device, and not the SD card. Instead of showing this info on the drives widget, it might be better to display it within the folder view when you open the device in Files, just like File Explorer.

[ferrariofilippo]

I'm not sure on how to proceed for implementation:

it might be better to display it within the folder view when you open the device in Files, just like File Explorer.

The issue is that it is a common folder, how should we display storage infos?
Should we add a new "secret" layout that is used only to display this kind of information?
Should we display the size only with tile view and/or add columns to the details layout?
An alternative could be to add the SD card to the Home page (basically we would fetch all the subfolders (phone and cards) and create a card for each one

[yaira2]

The details layout should be the easiest to update. We can add some additional columns and make them visible by default when opening the right type of drive. Regarding the implementation, is there a way to determine when to load the details?

[ferrariofilippo]

The details layout should be the easiest to update. We can add some additional columns and make them visible by default when opening the right type of drive. Regarding the implementation, is there a way to determine when to load the details?

At the moment we're just checking whether the drive path starts with \\?\ , and if so we consider it an MTP device. Following this approach we can see if the folder path is at the root level for its drive.
Still, I see this is not the best approach (not all paths starting with \\?\ refers to an MTP device) and I'll try to find a different solution

Edit. Just found we may use StorageFolder.DisplayType == "Portable Device" in the root folder to decide if it's a phone/tablet

[yaira2]

Using the foundation added in #16717, we should be able to display the storage information for the contextual property.

[yaira2]

@ferrariofilippo thank you for this PR. Building on this foundation and the work in #16717, I've opened #16729.