Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening new main window on macOS uses about:blankhome #598

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

TitanNano
Copy link
Contributor

This should fix #593.

nsBrowserContentHandler.prototype.getArguments seems to have been removed, but there is now getNewWindowArgs and overriding that one fixes this bug for me.

@filips123 filips123 added this to the 2.13.2 milestone Dec 21, 2024
Copy link
Owner

@filips123 filips123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this seems fine.

@filips123 filips123 merged commit 4a0601c into filips123:main Dec 21, 2024
18 checks passed
@TitanNano TitanNano deleted the jovan/fix_macos_new_window branch December 21, 2024 13:33
@filips123 filips123 added the bug Something isn't working label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[macOS] App opens to "about:blankhome" after closing window without quitting
2 participants